Add genesis migration dual-write queue for new Core chain - #748
Merged
Conversation
After a relay transaction is confirmed on the legacy chain, enqueue it (fire-and-forget) into new_chain_queue. A background NewChainFlusher goroutine drains the queue and forwards transactions to the new Core chain via ConnectRPC/ForwardTransaction. Transactions are flushed sequentially in insertion order. Parallel flushing was considered and rejected: dev apps can act on behalf of other users, creating cross-user ordering dependencies that no simple partitioning scheme can safely handle. On error the flusher halts at the failing row (with a 2s backoff) and retries rather than skipping — skipping would violate ordering. Mempool full responses are retried separately with exponential backoff. Config knobs (all off by default): - newChainUrl: ConnectRPC endpoint of the bootstrap node - newChainQueueEnabled: turns on enqueueing in the relay path - newChainFlushEnabled: starts the background flusher goroutine - newChainFlushFromBlock: trims rows already covered by the backfill - newChainInsecureSkipVerify: disables TLS verification (e.g. localstack) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
# Conflicts: # config/config.go
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 33812938 | Triggered | Generic High Entropy Secret | a93cc8d | api/rate_limit_middleware_test.go | View secret |
| 33812938 | Triggered | Generic High Entropy Secret | a93cc8d | api/rate_limit_middleware_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The branch was cut when migrations were in the 0190s; main is now at 0231, so 0180 sorted misleadingly early. Content is unchanged — pg_migrate.sh tracks applied migrations by file md5, so the rename is a no-op for any DB that already ran it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_chain_queueNewChainFlushergoroutine drains the queue and forwards transactions to the new Core chain viaForwardTransactionConnectRPCOrdering
Transactions are flushed sequentially in insertion order. Parallel flushing was considered and rejected: dev apps can act on behalf of other users, creating cross-user ordering dependencies that no simple partitioning scheme can safely handle.
On error the flusher halts at the failing row (2s backoff + retry) rather than skipping — skipping would violate ordering. Mempool-full responses are retried separately with exponential backoff (500ms → 15s cap).
Config knobs (all off by default)
newChainUrlnewChainQueueEnablednewChainFlushEnablednewChainFlushFromBlocknewChainInsecureSkipVerifyTest plan
newChainQueueEnabledfirst to populate the queue before enabling the flusher🤖 Generated with Claude Code